Allow skipping maintenance tasks for list command #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysle
reviewed
Dec 23, 2023
I did this manually: Do you have a suggestion on how to automate this with a test? My only suggestion would be to modify |
uranusjr
previously approved these changes
Dec 25, 2023
gaborbernat
requested changes
Dec 28, 2023
auto-merge was automatically disabled
December 29, 2023 15:42
Head branch was pushed to by a user without write access
Done |
dukecat0
previously approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
Add a
--skip-maintenanceflag to the list command. This sets a new state on the_SharedLibsclass, that is used to skip the shared libs upgrade step by settingneeds_upgradeto False. This change allows the user to skip the functionality that reaches out topip, which makes executing the command a lot faster when offline.resolves #1081
Test plan
Introduced a new test case
test_skip_maintenance. It first adds some packages to introduce shared libs. It then verifies that a normallistcommand sets the expected state on theshared_libsobject. Then it verifies that runninglistwith--skip-maintenanceresults in state on theshared_libsobject that indicates that no upgrade was performed.Tested by running
nox -s tests-3.12